Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old style forms #457

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Remove old style forms #457

merged 2 commits into from
Aug 14, 2020

Conversation

kinnala
Copy link
Owner

@kinnala kinnala commented Aug 13, 2020

I think we are soon in the position to remove these and release 2.0.0.

@gdmcbain Do you think we should do it before or after JOSS review has officially completed or does it matter?

@kinnala kinnala requested a review from gdmcbain August 13, 2020 12:06
Copy link
Contributor

@gdmcbain gdmcbain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looking at the diffs, it's a nice simplification.

@gdmcbain
Copy link
Contributor

What else would be in mind for 2.0.0? Resolving get_dofs and find_dofs, as arose today in #456 ?

@gdmcbain
Copy link
Contributor

Not sure whether this is the place to start the 2.0.0 wishlist (also I don't know whether it matters: push out 2.0.0 with the obsolete form-style banished, then push and 3 and 4 with whatever: i can see the sense in adhering to semantic versioning but I don't know whether there are meaningful constraints on frequency at this stage).

But back to the wishlist. Following #446 and #453, I've been wondering whether perhaps indeed for 2.0.0, i.e. really quite soon, we should pull other examples back under the common licence as examples do contain important snippets which are partial extensions of the library which might make their way into the library (e.g. handing of Dirichlet conditions, building preconditioners with pyamg or amgcl, specific preconditioners like those developed so far for the Stokes equation, ...). Should most of those examples from #446 be provided with static meshes? And then maybe provide one example that just shows how to use pygmsh with skfem and just put that example under the pygmsh licence; say it might just redo ex01 but with (not particularly necessary but valid) explicit .boundaries and .subdomains. I'm thinking that a number of the examples might share static mesh files, so that there aren't too many lying around. A nice disk, for example, would cover a few and perhaps even a disk with distinguished subdomains for core and annulus might also serve as a simple disk if those subdomains are simply ignored. (I think that works and should be harmless enough.) Sorry, this should be two new issues: (i) 2.0.0 wishlist, (ii) shared static meshes to reclaim examples from pygmsh licence.

@kinnala kinnala merged commit 5d07cad into master Aug 14, 2020
@kinnala kinnala deleted the remove-old-style-forms branch March 13, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants